PL-34 Add module schema and settings #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
++ |
|
@Kbentham I'm seeing some errors when I pull this up on http://federated-search-demo.local/admin/config/development/configuration/inspect. It looks like there are some schema mismatches on the fields and index. I'm seeing errors in these files:
|
|
It looks like the schema system include a bit of type checking so i did not include that in the form validation. |
|
Okey doke. Everything is split up and this is reading clean. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://palantir.atlassian.net/browse/PL-34
Add schema and default settings config to module.
Install the config inspector module and verify that the schema matches the config.
Check out palantirnet/federated-search-demo#5 and use compose to install this branch to test.